Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react-markdown from 8.0.7 to 9.0.1 #126

Merged
merged 9 commits into from
Nov 22, 2024
Merged

Bump react-markdown from 8.0.7 to 9.0.1 #126

merged 9 commits into from
Nov 22, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2024 •
edited by ctw-joao-luis
Loading

Bumps react-markdown from 8.0.7 to 9.0.1.

Release notes

Sourced from react-markdown's releases.

9.0.1

  • d8e3787 Fix double encoding in new url transform
  • 55d8d83 Refactor docs to use createRoot

Full Changelog: remarkjs/react-markdown@9.0.0...9.0.1

9.0.0

Change

  • b67d714 Change to require Node.js 16 migrate: update too
  • ec2b134 Change to require React 18 migrate: update too
  • bf5824f Change to use exports migrate: don’t use private APIs
  • c383a45 Update @types/hast, utilities, plugins, etc migrate: update too
  • eca5e6b 08ead9e Replace transformImageUri, transformLinkUri w/ urlTransform migrate: see Add urlTransform
  • de29396 Remove linkTarget option by @​galabra in remarkjs/react-markdown#762 migrate: see Remove linkTarget
  • 4346276 Remove support for passing custom props to components migrate: see Remove includeElementIndex, Remove rawSourcePos, Remove sourcePos, Remove extra props passed to certain components
  • c0dfbd6 Remove UMD bundle from package migrate: use esm.sh or a CDN or so
  • e12b5e9 Remove prop-types migrate: use TypeScript
  • 4eb7aa0 Change to throw errors for removed props migrate: don’t pass options that don’t do things
  • 8aabf74 Change to improve error messages migrate: expect better messages

Full Changelog: remarkjs/react-markdown@8.0.7...9.0.0

Changelog

Sourced from react-markdown's changelog.

Changelog

All notable changes will be documented in this file.

9.0.0 - 2023-09-27

  • b67d714 Change to require Node.js 16
    migrate: update too
  • ec2b134 Change to require React 18
    migrate: update too
  • bf5824f Change to use exports
    migrate: don’t use private APIs
  • c383a45 Update @types/hast, utilities, plugins, etc
    migrate: update too
  • eca5e6b 08ead9e Replace transformImageUri, transformLinkUri w/ urlTransform
    migrate: see “Add urlTransform” below
  • de29396 Remove linkTarget option
    migrate: see “Remove linkTarget” below
  • 4346276 Remove support for passing custom props to components
    migrate: see “Remove includeElementIndex”, “Remove rawSourcePos”, “Remove sourcePos”, “Remove extra props passed to certain components” below
  • c0dfbd6 Remove UMD bundle from package
    migrate: use esm.sh or a CDN or so
  • e12b5e9 Remove prop-types
    migrate: use TypeScript
  • 4eb7aa0 Change to throw errors for removed props
    migrate: don’t pass options that don’t do things
  • 8aabf74 Change to improve error messages
    migrate: expect better messages

Add urlTransform

The transformImageUri and transformLinkUri were removed. Having two functions is a bit much, particularly because there are more URLs you might want to change (or which might be unsafe so we make them safe). And their name and APIs were a bit weird. You can use the new urlTransform prop instead to change all your URLs.

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @lichtblick-bot.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Fixes by me @ctw-joao-luis

  • I had to resolve an import issue after the update on PanelOverlay.tsx
  • On TextContent.tsx:
  • Had to cast rehypeRaw as PluggableList because after the update react-markdown is more strict with the types;
  • On linkRenderer I changed the linkProps type to React.AnchorHTMLAttributes ibecause by typing linkProps as React.AnchorHTMLAttributes, it allows the component to accept all of the props that a standard anchor element would, ensuring that it behaves correctly and in a type-safe manner

lichtblick-bot
lichtblick-bot previously approved these changes Aug 1, 2024
View reviewed changes
@lichtblick-bot
Copy link
Collaborator

@dependabot squash and merge

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 1, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-markdown-9.0.1 branch 2 times, most recently from de289c4 to 60cf8a2 Compare August 1, 2024 12:16
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-markdown-9.0.1 branch 3 times, most recently from 83b9c04 to c5c9aec Compare August 5, 2024 11:09
dependabot bot added 2 commits November 21, 2024 10:51
@dependabot @ctw-joao-luis
Bump react-markdown from 8.0.7 to 9.0.1
355301c 
Bumps [react-markdown](https://github.com/remarkjs/react-markdown) from 8.0.7 to 9.0.1.
- [Release notes](https://github.com/remarkjs/react-markdown/releases)
- [Changelog](https://github.com/remarkjs/react-markdown/blob/main/changelog.md)
- [Commits](remarkjs/react-markdown@8.0.7...9.0.1)

---
updated-dependencies:
- dependency-name: react-markdown
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @ctw-joao-luis
[dependabot skip] Fix yarn.lock
1faa3ab
@ctw-joao-luis ctw-joao-luis force-pushed the dependabot/npm_and_yarn/react-markdown-9.0.1 branch from 09dd670 to 1faa3ab Compare November 21, 2024 10:52
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 21, 2024

Dependabot tried to merge this PR, but received the following error from GitHub:

Repository rule violations found

At least 1 approving review is required by reviewers with write access.

aneuwald-ctw
aneuwald-ctw previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@aneuwald-ctw aneuwald-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aneuwald-ctw
aneuwald-ctw reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@aneuwald-ctw aneuwald-ctw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing approval, I approved by mistake

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

laisspportugal
laisspportugal approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@laisspportugal laisspportugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@ctw-joao-luis ctw-joao-luis merged commit 8083676 into main Nov 22, 2024
10 checks passed
@ctw-joao-luis ctw-joao-luis deleted the dependabot/npm_and_yarn/react-markdown-9.0.1 branch November 22, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctw-joao-luis ctw-joao-luis ctw-joao-luis left review comments

@aneuwald-ctw aneuwald-ctw aneuwald-ctw left review comments

@laisspportugal laisspportugal laisspportugal approved these changes

@lichtblick-bot lichtblick-bot lichtblick-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lichtblick-bot @laisspportugal @aneuwald-ctw @ctw-joao-luis